-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1686678 - Prepare Glean.js to publish for web extensions #48
Conversation
Only when a new tag is created.
command: npm install | ||
- run: | ||
name: NPM Authentication | ||
command: echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to remember to set this environment variable before tagging for the first time. I copied this code from the nimbus-shared
CI config, so I trust it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@badboy also has expertise here :)
@@ -73,6 +88,15 @@ workflows: | |||
- lint | |||
- unit-tests | |||
- check-qt-js | |||
- publish-webext: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also copied from the glean_parser
publishing CI task.
"build:test-webext": "cd tests/utils/webext/sample/ && npm install && npm run build:xpi", | ||
"prepublish:webext": "npm run build:webext && json -I -f package.json -e \"this.name=\\\"@mozilla/glean-webext\\\"\"", | ||
"publish:webext": "npm run prepublish:webext && npm publish", | ||
"postpublish": "json -I -f package.json -e \"delete this.name\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit weird, I know. But it is necessary since we plan to publish different packages from this same package.json
. Note that I set the correct name on the prepublish
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I will need to change the glean_parser template, because right now it just assumes the package will be called "glean". That was an oversight on my part. Apologies.
Mh, that's a good point. I don't really have any good input for this. Maybe check in the channel :)
Do we need to publish things in |
Eh, you are right. No we don't. |
Closing this in favour of #73 |
For the Glean.js web extension package I could only think of the name
@mozilla/glean-webext
, but I don't like it.Pls, help.
For reference, these are the logs of a publishing dry-run that I tested using the
npm run publish:webext
command: