Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1726327 - Implement the new text metric type #647

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

badboy
Copy link
Member

@badboy badboy commented Aug 19, 2021

The new text metric type is really just a long string,
but only allowed under specific circumstances.


Draft while I fix outstanding things:

  • glean_parser release with that metric: v4.0.0
  • glean_parser update in glean.js
  • schema update: #692

@badboy badboy marked this pull request as ready for review August 23, 2021 15:41
@badboy
Copy link
Member Author

badboy commented Aug 23, 2021

Ok, took me a moment to understand why the size check failed.
It turns out the check size once runs against the code in the current working directory.
And the second time it checks out the main branch to link in Glean, but then switches back and runs the benchmark code.

So it uses the updated benchmark code, which of course includes the changes to e.g. benchmarks/size/webext/max.js and thus fails.
It should really checkout main and run the benchmark there fully.

@brizental
Copy link
Contributor

Oh, also, are you also going to do the documentation stuff under Bug 1726327? If not, please file a follow-up for that :)

@badboy
Copy link
Member Author

badboy commented Aug 24, 2021

Oh, also, are you also going to do the documentation stuff under Bug 1726327? If not, please file a follow-up for that :)

Followup bug

badboy added 2 commits August 25, 2021 14:17
The new text metric type is really just a long string,
but only allowed under specific circumstances.
@badboy badboy merged commit 030d850 into mozilla:main Aug 25, 2021
@badboy badboy deleted the text-metric branch August 25, 2021 13:36
badboy added a commit to badboy/glean.js that referenced this pull request Aug 31, 2021
This reverts commit 030d850, reversing
changes made to b9ac92a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants