Bug 1726769 - Include development version in Qt/QML build #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is right to catch this error, but I think the fact that is being hit at all is symptomatic of something else. Will file a bug for further investigation.
Dexterp37
reviewed
Aug 25, 2021
| return getValueFromNestedObject(obj, index); | ||
| } catch(e) { | ||
| log(LOG_TAG, [ | ||
| "Error getting value from database.", |
There was a problem hiding this comment.
What is this about? It doesn't seem to be fitting in this PR: is this an attempt to work around baku's issue?
There was a problem hiding this comment.
Nope, it's an issue I found when I ran the unminified version to check that it worked. As I mention in the commit message, this is probably symptomatic of some other real issue, for which I opened a follow-up bug. If you prefer I can drop this commit from this PR and add it to another one.
Dexterp37
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersTests: This PR includes thorough tests or an explanation of why it does notCHANGELOG.mdor an explanation of why it does not need oneglean.jsfile inside the Qt library folder, which is... kinda horrible, but at this point, better than nothing.