Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1740772 - Expose Uploader, UploadResult and UploadResultStatus #951

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

brizental
Copy link
Contributor

@brizental brizental commented Nov 15, 2021

Left Qt out of this on purpose, seems to be a bit more involved to
expose these over there and no one is currently asking for it.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

Left Qt out of this on purpose, seems to be a bit more involved to
expose these over there and no one is currently asking for it.
@auto-assign auto-assign bot requested a review from chutten November 15, 2021 08:41
@Dexterp37 Dexterp37 requested review from Dexterp37 and removed request for chutten November 15, 2021 08:46
@brizental brizental merged commit a56ca58 into mozilla:main Nov 15, 2021
@brizental brizental deleted the 1740772-expose-uploader branch November 15, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants