Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1689547 - First attempt at providing a ping encryption plugin #96

Merged
merged 15 commits into from
Mar 12, 2021
Merged

Bug 1689547 - First attempt at providing a ping encryption plugin #96

merged 15 commits into from
Mar 12, 2021

Conversation

brizental
Copy link
Contributor

Opening this as a draft to get feedback on the encryption implementation.

@brizental brizental requested a review from acmiyaguchi March 4, 2021 16:16
@brizental brizental force-pushed the 1689547-encryption branch from 8ebe144 to 675bfbe Compare March 4, 2021 17:29
@brizental
Copy link
Contributor Author

@acmiyaguchi I attended to your review comments in 9b69d77 this commit :)

acmiyaguchi
acmiyaguchi reviewed Mar 9, 2021
View reviewed changes
Copy link
Contributor

@acmiyaguchi acmiyaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments :) What do you still have left in this PR?

glean/src/plugins/encryption.ts Outdated Show resolved Hide resolved
@brizental
Copy link
Contributor Author

Thanks for addressing my comments :) What do you still have left in this PR?

If I have your green light on the encryption I'll just request Alessio's review for sanity check on the Glean.js specific parts and merge! Thanks @acmiyaguchi :D

@brizental brizental marked this pull request as ready for review March 10, 2021 08:32
@brizental brizental requested a review from Dexterp37 March 10, 2021 08:33
Dexterp37
Dexterp37 requested changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments below. Did you check that "log pings" allow us to ... log pings with this?

glean/src/plugins/encryption.ts Outdated Show resolved Hide resolved
glean/tests/plugins/encryption.spec.ts Show resolved Hide resolved
glean/tests/plugins/encryption.spec.ts Outdated Show resolved Hide resolved
glean/tests/plugins/encryption.spec.ts Outdated Show resolved Hide resolved
glean/src/plugins/encryption.ts Outdated Show resolved Hide resolved
@brizental
Copy link
Contributor Author

brizental commented Mar 10, 2021 •
edited
Loading

Did you check that "log pings" allow us to ... log pings with this?

Nope, but I can check that and even go further and add a test for it.

@Dexterp37
Copy link
Contributor

Did you check that "log pings" allow us to ... log pings with this?

Nope, but I can check that and even go further and a test for it.

Yes please :)

@brizental brizental requested a review from Dexterp37 March 12, 2021 11:51
brizental
brizental commented Mar 12, 2021
View reviewed changes
glean/src/core/events/index.ts Show resolved Hide resolved
glean/src/core/pings/maker.ts Show resolved Hide resolved
glean/src/plugins/encryption.ts Show resolved Hide resolved
glean/src/core/pings/maker.ts Show resolved Hide resolved
@brizental brizental force-pushed the 1689547-encryption branch from 6dbf549 to 4a3cd1b Compare March 12, 2021 14:12
@brizental brizental merged commit 2c1481d into mozilla:main Mar 12, 2021
@brizental brizental deleted the 1689547-encryption branch March 12, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acmiyaguchi acmiyaguchi acmiyaguchi left review comments

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brizental @Dexterp37 @acmiyaguchi