Bug 1741898 - Don't enqueue multiple stop command on uploader dispatcher #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behaviour would enqueue a Stop command on the uploader dispatcher everytime a ping submit happening while the uploader was throttled or stopped due to other limitations. That resulted in the dispatcher being immediatelly stopped once it was resumed due to the throttling window being over, because the first command it would see would be a stop command. That could result in long lasting periods of time when the uploader was just stopped and not processing ping requests.
Dexterp37
requested changes
Nov 19, 2021
|
@brizental let's kindly also add a changelog entry |
Dexterp37
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behaviour would enqueue a Stop command on the
uploader dispatcher everytime a ping submit happening while
the uploader was throttled or stopped due to other limitations.
That resulted in the dispatcher being immediatelly stopped once
it was resumed due to the throttling window being over, because
the first command it would see would be a stop command.
That could result in long lasting periods of time when the uploader
was just stopped and not processing ping requests.
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersCHANGELOG.mdor an explanation of why it does not need oneDocumentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work