Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1697427 - Add a default ping name for the testing APIs #99

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

Dexterp37
Copy link
Contributor

The Glean testing APIs are designed so that when user calls testGetValue they are not required to
explicitly specify the name of the ping, unless they want to.
This fixes the existing testing APIs to stick to that convention.

The Glean testing APIs are designed so that when
user calls `testGetValue` they are not required to
explicitly specify the name of the ping, unless
they want to.
This fixes the existing testing APIs to stick to
that convention.
@Dexterp37 Dexterp37 requested a review from brizental March 10, 2021 11:20
@Dexterp37 Dexterp37 self-assigned this Mar 10, 2021
@Dexterp37 Dexterp37 changed the title Add a default ping name for the testing APIs Bug 1697427 - Add a default ping name for the testing APIs Mar 10, 2021
Copy link
Contributor

@brizental brizental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

glean/src/core/metrics/types/boolean.ts Outdated Show resolved Hide resolved
glean/src/core/metrics/types/datetime.ts Outdated Show resolved Hide resolved
@Dexterp37 Dexterp37 merged commit e87b844 into mozilla:main Mar 10, 2021
@Dexterp37 Dexterp37 deleted the test_api_ping branch March 10, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants