Bug 1597714 - Build for release when assembling Python release #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Yeah -- the ability to get nice backtraces was just theoretical, along the lines of "if it breaks for our users, it would be nice for them not to have to set up a full Rust environment to get a backtrace". But it's never actually been needed.
r+wc
Let's add a CHANGELOG entry for this, just in case it ends up having an unexpected impact (it shouldn't).
badboy
force-pushed
the
use-release-for-python
branch
from
688e327 to
f2df415
Compare
badboy
force-pushed
the
use-release-for-python
branch
2 times, most recently
from
97f491a to
9727b1b
Compare
badboy
force-pushed
the
use-release-for-python
branch
from
9727b1b to
742fa84
Compare
|
Guess #987 landed. Repushing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step to reduce the size of the library we ship this switches the Python build to contain the release builds.
I think this works. Controlling it through an environment variable used by the Makefile seemed easy enough, additionally the Python setup script can read the same one.
For the Windows builds we're calling cargo directly, so we just pass
--releasedirectly.We might lose some more readable stacktraces in case of bugs (but I guess so far we haven't received any of those anyway?)