Bug 1650787 - Implement the JWE metric type on the core and FFI #1062
Conversation
There was a problem hiding this comment.
Looks good overall. A few minor changes requested.
In hindsight, I would have preferred to have at least one language binding implemented here, to have better confidence on the "language to core" mechanism. But, for this one, it should be fine. Please note that you'll need to add docs in the language bindings PRs as well.
I have kotlin, swift and c# implemented already. I can add any one of them to this PR if you prefer. |
Nah, that's fine, let's not over-rotate on this for now. Let's fix the problems here and move on. Next time we can do it differently! :) |
brizental
force-pushed
the
1650787-jwe
branch
2 times, most recently
from
069b059 to
afd1408
Compare
* Fix RFC link in `validate_base64url_encoding`; * Validate each field in JWE separately and specifically; * Fix comment for `set` function; * Add tests for get_test_value_* functions; * Apply lints from new Rust version.
I decided to separate this into two parts, this one just with the core and ffi changes, the next with the addition of this metric type to the bindings.
I found a bug on https://github.com/mozilla/glean/blob/main/glean-core/src/error_recording.rs#L61, which the bindings PR will depend on too. If you notice, we jump on the count from 2 directly to 4. I'll send a separate PR to fix that.
This implementation was based on this document.