Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix int32 to ErrorType mapping #1063

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Fix int32 to ErrorType mapping #1063

merged 2 commits into from
Jul 17, 2020

Conversation

brizental
Copy link
Contributor

No description provided.

@auto-assign auto-assign bot requested a review from Dexterp37 July 16, 2020 15:54
@brizental brizental force-pushed the error-type-try-from branch from 7c3a9be to b1a7abe Compare July 16, 2020 15:56
Dexterp37
Dexterp37 approved these changes Jul 16, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Dexterp37 Dexterp37 self-requested a review July 16, 2020 16:01
@Dexterp37
Copy link
Contributor

Wait a second. @brizental why is the test failing on CI?

@brizental brizental force-pushed the error-type-try-from branch from fdee532 to 54a8c97 Compare July 17, 2020 11:11
@brizental brizental merged commit 2f85156 into mozilla:main Jul 17, 2020
@brizental brizental deleted the error-type-try-from branch July 17, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brizental @Dexterp37