Bug 1601550 - Enforce disk quota on pending pings directory #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
commented
Jul 30, 2020
|
I redirected this to @badboy as I won't be able to get to it today and won't be around tomorrow. |
brizental
force-pushed
the
1601550-pending-pings-quota
branch
from
f7d1dab to
240257b
Compare
badboy
reviewed
Jul 31, 2020
brizental
force-pushed
the
1601550-pending-pings-quota
branch
2 times, most recently
from
74cdd92 to
5e55a0b
Compare
brizental
force-pushed
the
1601550-pending-pings-quota
branch
from
980b308 to
50482c3
Compare
badboy
requested changes
Aug 4, 2020
There was a problem hiding this comment.
Still some open questions and some suggestions.
This is on a good way though.
This definitely needs some documentation, e.g. user-facing here: https://mozilla.github.io/glean/book/user/pings/index.html?highlight=rate#limitations
brizental
force-pushed
the
1601550-pending-pings-quota
branch
2 times, most recently
from
636c82a to
f57b4e1
Compare
brizental
force-pushed
the
1601550-pending-pings-quota
branch
from
7a12c62 to
1c90936
Compare
badboy
approved these changes
Aug 6, 2020
glean-core/android/src/test/java/mozilla/telemetry/glean/pings/DeletionPingTest.kt
Show resolved
Hide resolved
brizental
requested review from
badboy and
Dexterp37
and removed request for
Dexterp37
badboy
approved these changes
Aug 7, 2020
The test was not checking if pings were actually loadedfrom disk
Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
The problem was that the test was trying to get a request sent by a worker, but that worker received a PingUploadTask::Wait before getting a PingUploadTask::Upload and the test was trying to check the request before it had actually arrived. This is potentially an issue with more tests, but it only manifested in this test for now. I opened Bug 1657589 for more in depth investigation on this.
Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
brizental
force-pushed
the
1601550-pending-pings-quota
branch
from
26f2a1f to
0979629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am opening this as a draft because I would like to get some opinions on the approach.
Please refer to comments I'll leave in the code to see what I mean.