Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1644364 - Move logic to limit max retries on recoverable failures to glean-core #1120

Merged
merged 8 commits into from
Aug 4, 2020
Merged

Bug 1644364 - Move logic to limit max retries on recoverable failures to glean-core #1120

merged 8 commits into from
Aug 4, 2020

Conversation

brizental
Copy link
Contributor

No description provided.

@auto-assign auto-assign bot requested a review from Dexterp37 August 3, 2020 16:23
Dexterp37
Dexterp37 requested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice overall, this is a good improvement!

glean-core/src/upload/mod.rs Outdated Show resolved Hide resolved
glean-core/src/upload/mod.rs Outdated Show resolved Hide resolved
glean-core/src/upload/mod.rs Outdated Show resolved Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/scheduler/PingUploadWorker.kt Outdated Show resolved Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/scheduler/PingUploadWorker.kt Show resolved Hide resolved
glean-core/csharp/Glean/Net/BaseUploader.cs Show resolved Hide resolved
glean-core/ios/Glean/Net/HttpPingUploader.swift Show resolved Hide resolved
glean-core/python/glean/net/ping_upload_worker.py Show resolved Hide resolved
glean-core/python/tests/test_network.py Show resolved Hide resolved
glean-core/src/upload/mod.rs Outdated Show resolved Hide resolved
@brizental
Limit retries for failed ping uploads from glean-core
9e8880c
@brizental
Remove recoverable failure limitation logic from bindings
93052ac
@brizental
Remove unnecessary changes to metrics.md
5beaa8b
@brizental
Fix python lints
bacd18e
@brizental
Update docstrings with new intent of PingUploadTask::Done
c88fb8d
@brizental
Attend to review comments
0af1433 
* period -> uploading window;
* get_upload_task_job -> get_upload_task_internal;
* Add comment to all bindings on how we avoind infinite loops;
* Correct position of incoming task comment in Kt;
* Add CHANGELOG.md entry;
@brizental brizental force-pushed the 1644364-limit-max-retries branch from 2bfcc25 to 0af1433 Compare August 4, 2020 10:30
@brizental brizental requested a review from Dexterp37 August 4, 2020 10:37
Dexterp37
Dexterp37 approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with the changelog update!

CHANGELOG.md Show resolved Hide resolved
@brizental brizental merged commit 78bee73 into mozilla:main Aug 4, 2020
@brizental brizental deleted the 1644364-limit-max-retries branch August 4, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brizental @Dexterp37