Bug 1682638 - Multiple fixes: Don't let the queue run, handle empty databases #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
reviewed
Dec 16, 2020
This test as of this commit fails.
There's no point in waiting for it to finish initialization if we're shutting down. There might be multiple operations queued, which could block for a long time. We should not hold off shutdown in those cases. Note: If Glean was already fully initialized shutdown will wait for these operations to finish before it shuts down.
Invalid means: either empty or not bincode-deserializable.
`test_reset_glean` will already do the right thing: * Destroys the Glean object if any * Resets the dispatcher, but only if Glean was initialized.
badboy
force-pushed
the
dont-crash-if-init-fails
branch
from
a25ab44 to
c0abb67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I identified 2 problems, that in combination cause the crashes in bug 1682638.
See document.
When init fails for some reason we never set a global Glean object. However on shutdown we try to unblock the dispatcher, which might have some recording tasks in there already. These should never be executed without a Glean.
The first 4 commits address that: we know when it is initialized, so we can avoid emptying the dispatcher if it hasn't.
For reasons unknown to me right now the database file was empty on at least the machine of one tester.
Rkv in safe-mode considers empty files as invalid files. I filed this upstream.
The solution (for now) is to remove that file and start over again.
For both cases I added new tests.