Bug 1713084 - Glean Plugin: Skip buildinfo generation for libraries #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE:
This removes support for the old API, passing a HashMap of ExtraKey -> String pairs.
The new API will look like this for consumers:
let mut extra = SomeExtra {
key1: Some("1".into()),
key2: Some("2".into)
};
metric.record(extra);
glean_parser will generate for the new API only.
When locally building or installing glean this file is generated. It trips up flake8, because it definitely does not correspond to its standards. It's auto-generated, so there's no need for linting, let's just ignore it.
Only one will be active, depending on whether the definition has type annotations. However to make it actually usable we need both generics around for now. When we remove the deprecated old style it will require removing the generic type here and changing the glean_parser
badboy
changed the title
badboy
force-pushed
the
skip-buildinfo-generation
branch
from
83a57ff
to
ac4765a
Compare
badboy
force-pushed
the
skip-buildinfo-generation
branch
from
ac4765a
to
97345da
Compare
Dexterp37
approved these changes
May 28, 2021
| @@ -76,7 +76,7 @@ if found_version != expected_version: | |||
| 'pip', | |||
| 'install', | |||
| '--upgrade', | |||
| 'git+ssh://git@github.com/mozilla/glean_parser@missing-event-imports#egg=glean_parser' | |||
| 'git+ssh://git@github.com/badboy/glean_parser@skip-buildinfo-generation#egg=glean_parser' | |||
There was a problem hiding this comment.
Reminder: restore this before merging
| @@ -416,7 +424,7 @@ except: | |||
|
|
|||
| // Setup a miniconda environment. conda is used because it works | |||
| // non-interactively on Windows, unlike the standard Python installers | |||
| conda "Miniconda3", "Miniconda3-${MINICONDA_VERSION}", "64", ["git+ssh://git@github.com/mozilla/glean_parser@missing-event-imports#egg=glean_parser"] | |||
| conda "Miniconda3", "Miniconda3-${MINICONDA_VERSION}", "64", ["git+ssh://git@github.com/badboy/glean_parser@skip-buildinfo-generation#egg=glean_parser"] | |||
There was a problem hiding this comment.
Reminder: restore this before merging
That PR was closed: should we rebase against |
mdboom
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires mozilla/glean_parser#341
PR against
new-event-extras, this will automatically rebase when PR#1567#1603 lands.