Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1753975 - Support expiration by major version on iOS #2013

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Apr 12, 2022

It's up to the embedding application to provide the correct version
number.

@badboy badboy marked this pull request as ready for review April 13, 2022 08:36
@auto-assign auto-assign bot requested a review from chutten April 13, 2022 08:36
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chutten
Copy link
Contributor

chutten commented Apr 14, 2022

Well, actually, it's missing a CHANGELOG entry

@badboy badboy force-pushed the ios/expire-by-version branch from 0acd77b to 8693b09 Compare April 14, 2022 15:39
It's up to the embedding application to provide the correct version
number.
@badboy badboy force-pushed the ios/expire-by-version branch from fed6409 to d025158 Compare April 14, 2022 16:06
@badboy badboy merged commit a943218 into main Apr 14, 2022
@badboy badboy deleted the ios/expire-by-version branch April 14, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants