Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1764573 - Only report the number of overflowing tasks in preinit_tasks_overflow metric #2026

Merged
merged 1 commit into from
May 2, 2022
Merged

Bug 1764573 - Only report the number of overflowing tasks in preinit_tasks_overflow metric #2026

merged 1 commit into from
May 2, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Apr 27, 2022

No description provided.

@badboy badboy force-pushed the 1764573-report-less-overflow branch from d17da6d to 6cad82a Compare April 27, 2022 13:49
@badboy badboy marked this pull request as ready for review April 27, 2022 13:50
@auto-assign auto-assign bot requested a review from travis79 April 27, 2022 13:50
@badboy badboy changed the title Only report the number of overflowing tasks in preinit_tasks_overflow metric Bug from 1764573- Only report the number of overflowing tasks in preinit_tasks_overflow metric Apr 27, 2022
@badboy badboy changed the title Bug from 1764573- Only report the number of overflowing tasks in preinit_tasks_overflow metric Bug 1764573 - Only report the number of overflowing tasks in preinit_tasks_overflow metric Apr 27, 2022
@badboy badboy requested review from chutten and removed request for travis79 April 27, 2022 13:53
chutten
chutten approved these changes Apr 27, 2022
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@chutten
Copy link
Contributor

chutten commented Apr 27, 2022

Also it looks like you missed another 110 in GleanTest.kt: https://searchfox.org/glean/source/glean-core/android/src/test/java/mozilla/telemetry/glean/GleanTest.kt#621

@badboy badboy force-pushed the 1764573-report-less-overflow branch from 6cad82a to 5674388 Compare April 27, 2022 14:52
@badboy badboy force-pushed the 1764573-report-less-overflow branch 2 times, most recently from feaa823 to 5f6ad8f Compare May 2, 2022 09:51
@badboy badboy force-pushed the 1764573-report-less-overflow branch from 5f6ad8f to c7d7398 Compare May 2, 2022 09:54
@badboy badboy enabled auto-merge (rebase) May 2, 2022 09:56
@badboy badboy merged commit d0f7836 into main May 2, 2022
@badboy badboy deleted the 1764573-report-less-overflow branch May 2, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 left review comments

@travis79 travis79 travis79 approved these changes

@chutten chutten chutten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@badboy @chutten @Dexterp37 @travis79