Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1766457 - Make source tag API public #2035

Merged
merged 2 commits into from
May 4, 2022
Merged

Bug 1766457 - Make source tag API public #2035

merged 2 commits into from
May 4, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented May 3, 2022 •
edited
Loading

No description provided.

@auto-assign auto-assign bot requested a review from chutten May 3, 2022 11:40
badboy added 2 commits May 3, 2022 13:43
@badboy
Make source tag API public
6e10c16
@badboy
Remove internal API from the docs
5fcfe1d 
They are not actually reachable by Swift users, only through
Glean.handleCustomUrl
@badboy badboy force-pushed the public-set-source-tags branch from 71fa209 to 5fcfe1d Compare May 3, 2022 11:43
chutten
chutten approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badboy badboy merged commit a23b723 into main May 4, 2022
@badboy badboy deleted the public-set-source-tags branch May 4, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chutten chutten chutten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badboy @chutten