Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1746181 - Implement the text metric for Kotlin and Swift #2073

Merged
merged 1 commit into from
May 30, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented May 27, 2022

Note: this is not required by anything really.
But it was so simple to implement I just went ahead.

@auto-assign auto-assign bot requested a review from Dexterp37 May 27, 2022 13:18
@badboy badboy force-pushed the uniffi-text-metric branch 2 times, most recently from d4e02f7 to fa50b49 Compare May 27, 2022 14:01
@badboy badboy requested a review from chutten May 27, 2022 14:17
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

docs/user/reference/metrics/text.md Outdated Show resolved Hide resolved
glean-core/src/lib_unit_tests.rs Outdated Show resolved Hide resolved
glean-core/src/metrics/text.rs Outdated Show resolved Hide resolved
glean-core/src/metrics/text.rs Outdated Show resolved Hide resolved
glean-core/src/metrics/text.rs Outdated Show resolved Hide resolved
glean-core/tests/text.rs Outdated Show resolved Hide resolved
glean-core/tests/text.rs Outdated Show resolved Hide resolved
@badboy badboy force-pushed the docs-for-java-now-correct branch from cc73d14 to 5492d8b Compare May 30, 2022 09:20
@badboy badboy force-pushed the uniffi-text-metric branch from fa50b49 to 639a618 Compare May 30, 2022 09:25
Base automatically changed from docs-for-java-now-correct to main May 30, 2022 09:26
@badboy badboy force-pushed the uniffi-text-metric branch from 639a618 to 8f55d69 Compare May 30, 2022 09:38
@badboy badboy enabled auto-merge (rebase) May 30, 2022 09:46
@badboy badboy merged commit 6913fc9 into main May 30, 2022
@badboy badboy deleted the uniffi-text-metric branch May 30, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants