Bug 1773262 - Relax glean_parser version requirement to "all compatible releases" #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
requested review from
chutten and
hackebrot
and removed request for
a team
badboy
force-pushed
the
relax-gleanparser-requirements
branch
from
609632c to
99724af
Compare
chutten
approved these changes
Jun 13, 2022
badboy
force-pushed
the
relax-gleanparser-requirements
branch
from
99724af to
c41f4aa
Compare
badboy
commented
Jun 14, 2022
gradle-plugin/src/main/groovy/mozilla/telemetry/glean-gradle-plugin/GleanGradlePlugin.groovy
Show resolved
Hide resolved
badboy
force-pushed
the
relax-gleanparser-requirements
branch
from
c41f4aa to
a5d4abc
Compare
badboy
force-pushed
the
relax-gleanparser-requirements
branch
from
a5d4abc to
3ca6efa
Compare
badboy
force-pushed
the
relax-gleanparser-requirements
branch
2 times, most recently
from
38f9741 to
c13e062
Compare
Previously it was in theory possible that it queries the Pypi index for packages if it can't find anything in the cache or wheels directory.
In pip `~=V.N` is equivalent to `>= V.N, == V.*` So we essentially allow everything from the specified minor version upwards until the next major version (excluded). As long as glean_parser is careful to not introduce breaking changes before that this will simplify work a lot by allowing small bug fixes without requiring subsequent Glean releases to bump versions all the time. This also relaxed the version check in the Glean Gradle Plugin. We always upgrade if in online mode. We allow semver-compatible versions in offline mode (we do the semver check ourselves to avoid more dependencies).
badboy
force-pushed
the
relax-gleanparser-requirements
branch
from
c13e062 to
b70a6c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pip
~=V.Nis equivalent to>= V.N, == V.*So we essentially allow everything from the specified minor version
upwards until the next major version (excluded).
As long as glean_parser is careful to not introduce breaking changes
before that this will simplify work a lot by allowing small bug fixes
without requiring subsequent Glean releases to bump versions all the
time.