Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1774550 - Use single quotes for strings in the Python inline script #2097

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Bug 1774550 - Use single quotes for strings in the Python inline script #2097

merged 1 commit into from
Jun 16, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Jun 16, 2022

No description provided.

@badboy badboy requested a review from a team as a code owner June 16, 2022 09:06
@badboy badboy requested review from chutten and removed request for a team June 16, 2022 09:06
@Dexterp37 Dexterp37 requested review from Dexterp37 and removed request for chutten June 16, 2022 09:08
Dexterp37
Dexterp37 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc.

I tested this locally in Fenix and it works as expected. Please add a changelog entry before merging.

@badboy badboy force-pushed the 1774550-nameerror-on-win branch from bebeb60 to b83c36c Compare June 16, 2022 09:30
@badboy badboy enabled auto-merge (rebase) June 16, 2022 09:30
@badboy badboy disabled auto-merge June 16, 2022 09:30
@badboy badboy merged commit 1c95771 into main Jun 16, 2022
@badboy badboy deleted the 1774550-nameerror-on-win branch June 16, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badboy @Dexterp37