Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1776445 - Bump the Android Gradle Plugin to v7.2.1 #2114

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

Dexterp37
Copy link
Contributor

This additionally bumps the Gradle version and fixes the breakage due to querying the namespace property at configuration time. We instead query it at evaluation time now.

This unblocks mozilla-mobile/android-components#12386

Note: I'm making this a draft until I test it in A-C.

@Dexterp37 Dexterp37 self-assigned this Jul 11, 2022
Copy link
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, just moving the code into the doFirst block is enough? Well, if CI agrees and the test in a-c works I have nothing against it.

@badboy
Copy link
Member

badboy commented Jul 11, 2022

CI failure for the clippy lints, that is fixed in main, so either rebase here or just ignore it and it will be green when merged.

@Dexterp37
Copy link
Contributor Author

Wait, just moving the code into the doFirst block is enough? Well, if CI agrees and the test in a-c works I have nothing against it.

Yes, because doFirst makes the code in its closure be executed as the [first thing when the task executes](https://docs.gradle.org/current/dsl/org.gradle.api.Task.html#org.gradle.api.Task:doFirst(org.gradle.api.Action) (vs configuration time)

This additionally bumps the Gradle version and fixes the
breakage due to querying the `namespace` property at
configuration time. We instead query it at evaluation time now.
@Dexterp37 Dexterp37 marked this pull request as ready for review July 13, 2022 09:16
@Dexterp37 Dexterp37 requested a review from a team as a code owner July 13, 2022 09:16
@Dexterp37 Dexterp37 requested review from travis79 and removed request for a team July 13, 2022 09:16
@Dexterp37
Copy link
Contributor Author

I tested this in Android Components and I was able to correctly build and run the Glean Sample app (all the other components built just fine).

@Dexterp37 Dexterp37 removed the request for review from travis79 July 13, 2022 09:26
@Dexterp37 Dexterp37 merged commit b7e51fe into mozilla:main Jul 13, 2022
@Dexterp37 Dexterp37 deleted the agp-7.2.1 branch July 13, 2022 10:17
@mcarare
Copy link
Contributor

mcarare commented Jul 15, 2022

@Dexterp37 Is there any timeline set for releasing the next version that contains this fix? TY!

@badboy
Copy link
Member

badboy commented Jul 15, 2022

@Dexterp37 Is there any timeline set for releasing the next version that contains this fix? TY!

We have a couple of things I'd like to bundle into a release, so we probably do a release end of next week, which means it will take until the week after that (July 25th) before it reaches A-C.

@mcarare
Copy link
Contributor

mcarare commented Jul 25, 2022

@badboy I guess app services should also be updated with the new Glean version and bumped before we can also update Glean in AC?

@badboy
Copy link
Member

badboy commented Jul 25, 2022

@badboy I guess app services should also be updated with the new Glean version and bumped before we can also update Glean in AC?

Yes, I'm working on that today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants