-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1776445 - Bump the Android Gradle Plugin to v7.2.1 #2114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, just moving the code into the doFirst
block is enough? Well, if CI agrees and the test in a-c works I have nothing against it.
gradle-plugin/src/main/groovy/mozilla/telemetry/glean-gradle-plugin/GleanGradlePlugin.groovy
Show resolved
Hide resolved
CI failure for the clippy lints, that is fixed in |
Yes, because |
This additionally bumps the Gradle version and fixes the breakage due to querying the `namespace` property at configuration time. We instead query it at evaluation time now.
I tested this in Android Components and I was able to correctly build and run the Glean Sample app (all the other components built just fine). |
@Dexterp37 Is there any timeline set for releasing the next version that contains this fix? TY! |
We have a couple of things I'd like to bundle into a release, so we probably do a release end of next week, which means it will take until the week after that (July 25th) before it reaches A-C. |
@badboy I guess app services should also be updated with the new Glean version and bumped before we can also update Glean in AC? |
Yes, I'm working on that today. |
This additionally bumps the Gradle version and fixes the breakage due to querying the
namespace
property at configuration time. We instead query it at evaluation time now.This unblocks mozilla-mobile/android-components#12386
Note: I'm making this a draft until I test it in A-C.