Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1772148 - Remove rkv safe-mode toggle. It's default enabled now. #2123

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Bug 1772148 - Remove rkv safe-mode toggle. It's default enabled now. #2123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,6 @@ commands:
command: |
export GLEAN_TEST_COVERAGE=$(realpath glean_coverage.txt)
cargo test --verbose --jobs 6 -- --nocapture
- run:
name: Test Glean with rkv safe-mode
command: |
cd glean-core
cargo test -p glean-core --features rkv-safe-mode --jobs 6 -- --nocapture
- run:
name: Install required Python dependencies
command: |
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
(`null`, `nil`, `None` depending on the language) and does not throw an exception ([#2087](https://github.com/mozilla/glean/pull/2087)).
* BREAKING CHANGE: Dropped `ping_name` argument from all `test_get_num_recorded_errors` methods ([#2088](https://github.com/mozilla/glean/pull/2088))
Errors default to the `metrics` ping, so that's what is queried internally.
* BREAKING: Disable `safe-mode` everywhere. This causes all clients to migrate from LMDB to safe-mode storage ([#2123](https://github.com/mozilla/glean/pull/2123))
* Kotlin
* Fix the Glean Gradle Plugin to work with Android Gradle Plugin v7.2.1 ([#2114](https://github.com/mozilla/glean/pull/2114))
* Rust
Expand Down
4 changes: 0 additions & 4 deletions glean-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,3 @@ ctor = "0.1.12"

[build-dependencies]
uniffi_build = { version = "0.19.3", features = ["builtin-bindgen"] }

[features]
# Enable the "safe-mode" Rust storage backend instead of the default LMDB one.
rkv-safe-mode = []
4 changes: 0 additions & 4 deletions glean-core/bundle-android/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,3 @@ path = "../bundle/src/lib.rs"
[dependencies.glean-core]
# No version specified, we build against what's available here.
path = ".."

[features]
# Enable the "safe-mode" Rust storage backend instead of the default LMDB one.
rkv-safe-mode = ["glean-core/rkv-safe-mode"]
4 changes: 0 additions & 4 deletions glean-core/bundle/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,3 @@ crate-type = ["staticlib", "cdylib"]
[dependencies.glean-core]
# No version specified, we build against what's available here.
path = ".."

[features]
# Enable the "safe-mode" Rust storage backend instead of the default LMDB one.
rkv-safe-mode = ["glean-core/rkv-safe-mode"]
2 changes: 0 additions & 2 deletions glean-core/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,6 @@ def run(self):
"glean-bundle",
"--target",
target,
"--features",
"rkv-safe-mode",
]
if buildvariant != "debug":
command.append(f"--{buildvariant}")
Expand Down
4 changes: 0 additions & 4 deletions glean-core/rlb/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,3 @@ env_logger = { version = "0.9.0", default-features = false, features = ["termcol
tempfile = "3.1.0"
jsonschema-valid = "0.5.0"
flate2 = "1.0.19"

[features]
# Enable the "safe-mode" Rust storage backend instead of the default LMDB one.
rkv-safe-mode = ["glean-core/rkv-safe-mode"]
Loading