Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1784249 - Upgrade to Android NDK r25 #2159

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Bug 1784249 - Upgrade to Android NDK r25 #2159

merged 2 commits into from
Aug 18, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Aug 12, 2022

This reverts commit dee4e7a.

The updated rust-android-gradle plugin takes care of fixing up the build and using the right tools

@badboy badboy requested a review from a team as a code owner August 12, 2022 11:29
@badboy badboy requested review from chutten and removed request for a team August 12, 2022 11:29
@badboy badboy force-pushed the ndk-r25-once-again branch from e7c3688 to f8a5521 Compare August 12, 2022 13:18
@badboy badboy changed the title Bug 1784249 - Revert "Go back to NDK 21" [ci full] Bug 1784249 - Upgrade to Android NDK r25 Aug 12, 2022
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs CHANGELOG

badboy added 2 commits August 15, 2022 11:52
This reverts commit dee4e7a.
This one comes with full support for NDK r23+, including the
s/-lgcc/-lunwind/ fix and usage of llvm-ar instead of triple-specific
tools.
@badboy badboy force-pushed the ndk-r25-once-again branch from f8a5521 to 0f295bc Compare August 15, 2022 09:52
@badboy badboy merged commit 1695d49 into main Aug 18, 2022
@badboy badboy deleted the ndk-r25-once-again branch August 18, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants