Bug 1789615 - Always store a UUID hyphenated #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression in the Glean Python SDK. We used to do this, but failed to correctly encode UUIDs since v50. The Glean ping schema expects UUIDs in a hyphenated form a la `060f830d-3bcc-4a6a-b4b1-7336271a2b34`. However we passed the user data through without re-encoding, thus leading to non-hyphenated strings landing in the JSON payload of a ping and then getting rejected by the pipeline. This is only an issue for Python, because for Kotlin and Swift we don't accept plain strings, but only `UUID` types, which serialize to hyphenated strings.
badboy
force-pushed
the
python-handle-non-hyphenated-uuid
branch
from
c7cac3c to
f9d58a9
Compare
perrymcmanis144
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in the Glean Python SDK.
We used to do this, but failed to correctly encode UUIDs since v50.
The Glean ping schema expects UUIDs in a hyphenated form a la
060f830d-3bcc-4a6a-b4b1-7336271a2b34. However we passed the user data through without re-encoding, thus leading to non-hyphenated strings landing in the JSON payload of a ping and then getting rejected by the pipeline.This is only an issue for Python, because for Kotlin and Swift we don't accept plain strings, but only
UUIDtypes, which serialize to hyphenated strings.