-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use single-quote to ensure code is valid when executed on Windows #2193
Conversation
fe0d15a
to
e88e368
Compare
gradle-plugin/src/main/groovy/mozilla/telemetry/glean-gradle-plugin/GleanGradlePlugin.groovy
Outdated
Show resolved
Hide resolved
e88e368
to
5bf4853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested this on my Windows machine within A-C. This works for me!
@badboy Do you have an estimate of when this will land on Fenix? |
We need to cut a new release. This will likely happen next week as this week we're at a company wide meeting. |
@Dexterp37 when it will be done |
@Dexterp37 I tried yesterday to make a build for AMO stage addon installs - > debug variant, I still get this error |
@sum20156 a new release was cut yesterday and it's now being picked up by the products using Glean.
@ioanarusiczki what's the specific product and steps to reproduce? If it's addons then it's the Glean JS SDK probably, which lives in mozilla/glean.js |
@Dexterp37 to reproduce..I just freshly cloned the repo...branch is main and the build variant is debug |
@sum20156 sorry for the confusion, I was asking @ioanarusiczki about how to reproduce, as their problem is likely for another product. Fenix is going to use the freshly cut Glean version soon. |
@Dexterp37 It's the same as @sum20156 said, I cloned the repo (a while ago), yesterday I've updated the repo. My variant is debug. I get the following errors: |
Oh, I see, so it's still Fenix (sorry I was confused by what addons-frontend was). Then the answer is the same: the latest version is getting adopted by new products. The new fix will like be in Fenix tomorrow. Sorry for the delay, it's been all hands + flying back so this week stuff is mostly slow. |
@Dexterp37 No problem, thanks for the info. |
@Dexterp37 thanks! it worked |
Glad to hear :) Thanks go to @perrymcmanis144 and @chutten who shipped the release :-) |
Should fix mozilla-mobile/fenix#27053
Fixes #2192