Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single-quote to ensure code is valid when executed on Windows #2193

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Sep 19, 2022

@badboy badboy requested a review from Dexterp37 September 19, 2022 08:54
@badboy badboy requested a review from a team as a code owner September 19, 2022 08:54
@badboy badboy force-pushed the fix-python-on-windows-in-plugin branch from fe0d15a to e88e368 Compare September 19, 2022 08:54
@Dexterp37
Copy link
Contributor

Fixes mozilla-mobile/fenix#27053

@badboy badboy force-pushed the fix-python-on-windows-in-plugin branch from e88e368 to 5bf4853 Compare September 19, 2022 10:05
@badboy badboy requested a review from Dexterp37 September 19, 2022 10:05
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this on my Windows machine within A-C. This works for me!

@badboy badboy merged commit f5aa432 into main Sep 19, 2022
@badboy badboy deleted the fix-python-on-windows-in-plugin branch September 19, 2022 13:26
@sv-ohorvath
Copy link

sv-ohorvath commented Sep 26, 2022

@badboy Do you have an estimate of when this will land on Fenix?

@Dexterp37
Copy link
Contributor

@badboy Do you have an estimate of when this will land on Fenix?

We need to cut a new release. This will likely happen next week as this week we're at a company wide meeting.

@sum20156
Copy link

sum20156 commented Oct 6, 2022

@Dexterp37 when it will be done

@ioanarusiczki
Copy link

@Dexterp37 I tried yesterday to make a build for AMO stage addon installs - > debug variant, I still get this error

@Dexterp37
Copy link
Contributor

@Dexterp37 when it will be done

@sum20156 a new release was cut yesterday and it's now being picked up by the products using Glean.

@Dexterp37 I tried yesterday to make a build for AMO stage addon installs - > debug variant, I still get this error

@ioanarusiczki what's the specific product and steps to reproduce? If it's addons then it's the Glean JS SDK probably, which lives in mozilla/glean.js

@sum20156
Copy link

sum20156 commented Oct 6, 2022

@Dexterp37 to reproduce..I just freshly cloned the repo...branch is main and the build variant is debug

@Dexterp37
Copy link
Contributor

@Dexterp37 to reproduce..I just freshly cloned the repo...branch is main and the build variant is debug

@sum20156 sorry for the confusion, I was asking @ioanarusiczki about how to reproduce, as their problem is likely for another product. Fenix is going to use the freshly cut Glean version soon.

@ioanarusiczki
Copy link

@Dexterp37 It's the same as @sum20156 said, I cloned the repo (a while ago), yesterday I've updated the repo.
I must change a few lines so the build would let the addon installation happen on AMO stage, it's here:
mozilla/addons-frontend@e65a006

My variant is debug.

I get the following errors:

errors in AS

@Dexterp37
Copy link
Contributor

Oh, I see, so it's still Fenix (sorry I was confused by what addons-frontend was).

Then the answer is the same: the latest version is getting adopted by new products. The new fix will like be in Fenix tomorrow.

Sorry for the delay, it's been all hands + flying back so this week stuff is mostly slow.

@ioanarusiczki
Copy link

@Dexterp37 No problem, thanks for the info.

@ioanarusiczki
Copy link

@Dexterp37 thanks! it worked

epic win

@Dexterp37
Copy link
Contributor

@Dexterp37 thanks! it worked

epic win

Glad to hear :) Thanks go to @perrymcmanis144 and @chutten who shipped the release :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org.gradle.api.GradleException: Glean code generation failed [Bug]: Glean code generation failed.
5 participants