-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1790949 - Bump URL metric limit to 8k #2199
Merged
badboy
merged 12 commits into
mozilla:main
from
rosahbruno:1790949-bump-url-metric-limit-to-8k
Sep 21, 2022
Merged
Bug 1790949 - Bump URL metric limit to 8k #2199
badboy
merged 12 commits into
mozilla:main
from
rosahbruno:1790949-bump-url-metric-limit-to-8k
Sep 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
I believe the tests are failing because of the issues that should be getting fixed in #2198 |
travis79
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, the beta tests are failing because of an unrelated Rust change. This looks great!
badboy
requested changes
Sep 21, 2022
badboy
approved these changes
Sep 21, 2022
badboy
changed the title
Bug 1790949 - bump url metric limit to 8k
Bug 1790949 - Bump URL metric limit to 8k
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the URL metric to have an 8k limit. Also updated the docs to reflect the new URL length.
Glean.js PR - mozilla/glean.js#1513