Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1790949 - Bump URL metric limit to 8k #2199

Merged
merged 12 commits into from
Sep 21, 2022

Conversation

rosahbruno
Copy link
Contributor

@rosahbruno rosahbruno commented Sep 20, 2022

Update the URL metric to have an 8k limit. Also updated the docs to reflect the new URL length.

Glean.js PR - mozilla/glean.js#1513

@rosahbruno
Copy link
Contributor Author

I believe the tests are failing because of the issues that should be getting fixed in #2198

@rosahbruno rosahbruno marked this pull request as ready for review September 20, 2022 19:51
@rosahbruno rosahbruno requested a review from a team as a code owner September 20, 2022 19:51
@rosahbruno rosahbruno requested review from chutten and removed request for a team September 20, 2022 19:51
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the beta tests are failing because of an unrelated Rust change. This looks great!

CHANGELOG.md Outdated Show resolved Hide resolved
glean-core/src/metrics/url.rs Outdated Show resolved Hide resolved
@rosahbruno rosahbruno requested a review from badboy September 21, 2022 13:41
@badboy badboy changed the title Bug 1790949 - bump url metric limit to 8k Bug 1790949 - Bump URL metric limit to 8k Sep 21, 2022
@badboy badboy merged commit 9680e47 into mozilla:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants