-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1821437 - Upgrade to Xcode 14.0 #2253
Conversation
ff74617
to
f0bf1cb
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2253 +/- ##
=======================================
Coverage 31.70% 31.70%
=======================================
Files 1 1
Lines 41 41
=======================================
Hits 13 13
Misses 28 28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc
@badboy IIUC, Firefox and Focus iOS are both on XCode 14.3 now. Are there other consumers that need to update or can this land now? |
This is essentially a revert of the revert-commit f941d76 again, adopting it to the latest release. Installed software: https://circle-macos-docs.s3.amazonaws.com/image-manifest/v12131/manifest.txt
Nope, that should be it. I just haven't tracked it closely and so missed them upgrading. I'll get this PR updated and landed. |
f0bf1cb
to
d837d6a
Compare
@@ -513,14 +513,14 @@ jobs: | |||
- setup-rust-toolchain | |||
- restore_cache: | |||
name: Restore rubygems cache | |||
key: swift-docs-gems-v13 | |||
key: swift-docs-gems-v15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used -v14
in the reverted commit before. Thus skipping that and going for v15 right away.
d837d6a
to
444ee59
Compare
Waiting for clarification here: mozilla-mobile/focus-ios#3765 |
This is essentially a revert of the revert-commit f941d76 again.
We can hold off until our consumers are good to go with this.