Record new error type "invalid state" to accurately describe the… #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
approved these changes
Aug 6, 2019
Dexterp37
requested changes
Aug 6, 2019
There was a problem hiding this comment.
I like the idea and the implementation. As @badboy said, we should merge this after we drop glean-ac. It's fine to change things for existing metrics, I think, in this case: we're specifying a new error class to better catch problems.
I'm holding back r+ on this to make sure this lands after we release glean-core.
mdboom
changed the title
travis79
approved these changes
Oct 24, 2019
Dexterp37
approved these changes
Oct 24, 2019
mdboom
approved these changes
Oct 24, 2019
CAUTION: This might change error reporting for existing metrics.
badboy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAUTION: This might change error reporting for existing metrics.
We should decide if we want that.
That will only apply once we drop Glean AC (or we would need to also backport this)