Bug 1820792 - Create new RKV on DatabaseCorrupted Error and log error #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrymcmanis144
force-pushed
the
enable_db_corrupted_error
branch
from
30ac8ef to
58756b4
Compare
|
fun fact: it seems rkv has that ability already and I just agreed to even generalize it a bit more (here) |
badboy
requested changes
Mar 24, 2023
There was a problem hiding this comment.
👍 This seems better than the status quo because at least we would get back to a working state again.
It would be great if we start recording when these errors happen so we actually know how frequent that is.
That will require some plumbing to pass back the error and record it once we have a database though. Best done in a followup, could you file a bug?
We should also rebase this once the latest release has landed in main so that the changelog ends up in the right place.
Co-authored-by: Jan-Erik Rediger <jrediger@mozilla.com>
badboy
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up so we can discuss/not forget about it