Bug 1818361 - Prevent another test-only issue: The storage going away when the uploader reports back its status #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "No database found" message is unique, so we _always_ know that it happens in exactly that line. That's not helpful during debugging though. We want to know which part requested storage. `track_caller` does that. See https://doc.rust-lang.org/reference/attributes/codegen.html#the-track_caller-attribute
…ader reports back its status We already do this for counters and timing distributions. Now for memory distributions as well. All metric types used by the uploader itself.
badboy
force-pushed
the
gracefully-handling-missing-glean-in-uploader-better
branch
from
ba1165f to
610dbb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "No database found" message is unique, so we always know that it
happens in exactly that line.
That's not helpful during debugging though. We want to know which part
requested storage.
track_callerdoes that.See https://doc.rust-lang.org/reference/attributes/codegen.html#the-track_caller-attribute
This is more of a workaround than a fix and we should eventually follow this up with properly addressing this in a more holistic way