Bug 1827852 - Extend start/stop time of a ping to millisecond precision #2456
Conversation
badboy
force-pushed
the
start-end-time-milliseconds
branch
4 times, most recently
from
8e16a02
to
d03bb10
Compare
badboy
force-pushed
the
start-end-time-milliseconds
branch
from
d03bb10
to
c83d3cd
Compare
badboy
force-pushed
the
start-end-time-milliseconds
branch
from
c83d3cd
to
8bc7031
Compare
badboy
force-pushed
the
start-end-time-milliseconds
branch
5 times, most recently
from
9cf3397
to
0f8775f
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2456 +/- ##
=======================================
Coverage 33.33% 33.33%
=======================================
Files 1 1
Lines 42 42
=======================================
Hits 14 14
Misses 28 28
☔ View full report in Codecov by Sentry. |
badboy
force-pushed
the
start-end-time-milliseconds
branch
from
0f8775f
to
5c66891
Compare
Uh oh! Looks like an error! DetailsTaskcluster-GitHub attempted to cancel previously created task groups with following scopes: Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes: This request requires the client to satisfy the following scope expression:
|
badboy
force-pushed
the
start-end-time-milliseconds
branch
from
5c66891
to
61c73ad
Compare
Uh oh! Looks like an error! DetailsTaskcluster-GitHub attempted to cancel previously created task groups with following scopes: Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes: This request requires the client to satisfy the following scope expression:
|
badboy
force-pushed
the
start-end-time-milliseconds
branch
from
61c73ad
to
d1e3345
Compare
Uh oh! Looks like an error! DetailsTaskcluster-GitHub attempted to cancel previously created task groups with following scopes: Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes: This request requires the client to satisfy the following scope expression:
|
| @@ -29,6 +29,7 @@ In addition to those built-in metrics, the following metrics are added to the pi | |||
|
|
|||
| | Name | Type | Description | Data reviews | Extras | Expiration | [Data Sensitivity](https://wiki.mozilla.org/Firefox/Data_Collection) | | |||
| | --- | --- | --- | --- | --- | --- | --- | | |||
| | glean.client.annotation.experimentation_id |[string](https://mozilla.github.io/glean/book/user/metrics/string.html) |An experimentation identifier derived and provided by the application for the purpose of experimentation enrollment. |[Bug 1848201](https://bugzilla.mozilla.org/show_bug.cgi?id=1848201#c5)||never |1 | | |||
There was a problem hiding this comment.
🤔 Don't we recommend folks use the Glean Dictionary for this stuff? (Non-blocking, just thinking out loud about filing a bug)
There was a problem hiding this comment.
yeah, we do. for others. We still have it and whether we should or not should go into a separate bug.
| @@ -498,8 +500,6 @@ glean.error: | |||
| Only sent if the buffer ever overflows. | |||
|
|
|||
| In Version 0 this reported the total number of tasks enqueued. | |||
| unit: | |||
There was a problem hiding this comment.
o_O. Where did this come from? Ahh, cool! Even though unit has not meaning here, it still shows up in the Glean dictionary. Maybe this would be okay to leave as I kinda like the explicit documentation this metadata provides (though the description should do that, too) 🤔
No strong opinions on this, happy either way.
There was a problem hiding this comment.
I was equally surprised!
We just disallowed this in glean_parser. So we would need to retract that decision, which would require a bug, a revert and a new release.
Requires mozilla/glean_parser#592