Bug 1812738 - allow user to set Glean log level

[rosahbruno]

Allow the ability to configure the logging levels of Glean.

[rosahbruno]

@travis79
What are your thoughts on how I did this?

I set this up so that you can just call the function with your log preference. The other debug options all go through debug.rs and work a little differently since they rely on knowing if Glean is initialized or not. Since this is just a setting for the crate itself, it doesn't really care what is going on with Glean. I can update this to work similarly to the other debug options if we want this to feel the same.

[travis79]

I think this should be fine. I actually envisioned this added as a parameter to the configuration passed into Glean.initialize, that way it's not adding the burden of calling an additional API to set the logging level

[badboy]

I think this should be fine. I actually envisioned this added as a parameter to the configuration passed into Glean.initialize, that way it's not adding the burden of calling an additional API to set the logging level

Note that on Python we already pass in the log level, see https://mozilla.github.io/glean/book/user/debugging/python.html#logging-pings
We should stay consistent then and have it the same across languages (due to how things work the Python bindings configure the log level on the Python logger instance, not on the Rust side)

[travis79]

I think this should be fine. I actually envisioned this added as a parameter to the configuration passed into Glean.initialize, that way it's not adding the burden of calling an additional API to set the logging level

Note that on Python we already pass in the log level, see mozilla.github.io/glean/book/user/debugging/python.html#logging-pings We should stay consistent then and have it the same across languages (due to how things work the Python bindings configure the log level on the Python logger instance, not on the Rust side)

Ahh, I'd forgotten that we had this in Python 🤦. Yes, let's go with consistency!

[rosahbruno]

@badboy @travis79
Updated based on the feedback

[badboy]

Sorry for one more round of sending this back.

[travis79]

I lean in @badboy's direction here on the default level of the logging, but no need to block on further review, I think.

[rosahbruno]

@badboy
I've addressed the comments you left. Now the logging level is only overwritten if provided by the user, otherwise it uses what we set elsewhere. I also updated the comments to call out "internal logging" rather than the rust crate.