Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize Gradle dependencies with Android Components #2462

Merged
merged 1 commit into from
May 5, 2023
Merged

Synchronize Gradle dependencies with Android Components #2462

merged 1 commit into from
May 5, 2023

Conversation

rvandermeulen
Copy link
Contributor

No description provided.

Dexterp37
Dexterp37 reviewed May 5, 2023
View reviewed changes
build.gradle Show resolved Hide resolved
@rvandermeulen rvandermeulen marked this pull request as ready for review May 5, 2023 14:04
@rvandermeulen rvandermeulen requested a review from a team as a code owner May 5, 2023 14:04
@rvandermeulen rvandermeulen requested review from chutten and removed request for a team May 5, 2023 14:04
chutten
chutten approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the changelog, this LGTM. It's a patch (1.8.20 - 1.8.21) update, so I don't feel we need to clear it with our non-AC consumers before giving the okay.

@chutten chutten merged commit 280e980 into mozilla:main May 5, 2023
@rvandermeulen rvandermeulen deleted the rvm_gradle branch May 15, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 left review comments

@chutten chutten chutten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvandermeulen @Dexterp37 @chutten