Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1838174 - Upgrade to Gradle 8.2.1 and Android Gradle Plugin 8.0.2 [ci full] #2516

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Bug 1838174 - Upgrade to Gradle 8.2.1 and Android Gradle Plugin 8.0.2 [ci full] #2516

merged 2 commits into from
Aug 11, 2023

Conversation

badboy
Copy link
Member

@badboy badboy commented Jun 27, 2023

Supersedes #2500

@badboy
Copy link
Member Author

badboy commented Jun 27, 2023

There's still some warnings during packaging:

[task 2023-06-27T08:56:38.600Z] > Task :glean:releaseSourcesJar
[task 2023-06-27T08:56:38.600Z] Encountered duplicate path "main/mozilla/telemetry/glean/Dispatchers.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.600Z] Encountered duplicate path "main/mozilla/telemetry/glean/Glean.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.601Z] Encountered duplicate path "main/mozilla/telemetry/glean/config/Configuration.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/debug/GleanDebugActivity.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/net/BaseUploader.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/net/HttpURLConnectionUploader.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/net/PingUploader.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/net/Upload.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/Aliases.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/BooleanMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/CounterMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/CustomDistributionMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/DatetimeMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/DenominatorMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/EventMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/HistogramBase.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/LabeledMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/MemoryDistributionMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/NumeratorMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/PingType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/QuantityMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/RateMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/StringListMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/StringMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/TextMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/TimespanMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/TimingDistributionMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/UrlMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/private/UuidMetricType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/scheduler/GleanLifecycleObserver.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/scheduler/MetricsPingScheduler.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/scheduler/PingUploadWorker.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/testing/ErrorType.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/testing/GleanTestLocalServer.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/testing/GleanTestRule.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/utils/DataPathUtils.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/utils/DateUtils.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/utils/GzipUtils.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/utils/JsonUtils.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/utils/LocaleUtils.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/utils/ThreadUtils.kt" during copy operation configured with DuplicatesStrategy.WARN
[task 2023-06-27T08:56:38.602Z] Encountered duplicate path "main/mozilla/telemetry/glean/utils/WorkManagerUtils.kt" during copy operation configured with DuplicatesStrategy.WARN

@badboy badboy marked this pull request as ready for review July 12, 2023 10:10
@badboy badboy requested a review from a team as a code owner July 12, 2023 10:10
@badboy badboy requested review from perrymcmanis144 and removed request for a team July 12, 2023 10:10
@badboy
Copy link
Member Author

badboy commented Jul 12, 2023

I still need to test that the GleanMetricsYamlTransform part works as expected in Fenix.

@badboy
Copy link
Member Author

badboy commented Jul 12, 2023

fwiw I looked at https://stackoverflow.com/questions/71365373/software-components-will-not-be-created-automatically-for-maven-publishing-from and https://developer.android.com/build/publish-library/configure-pub-variants to understand that singleVariant part

@badboy
Copy link
Member Author

badboy commented Jul 12, 2023

I still need to test that the GleanMetricsYamlTransform part works as expected in Fenix.

Done.

@badboy badboy requested a review from travis79 July 12, 2023 12:19
@mcarare
Copy link
Contributor

mcarare commented Jul 21, 2023

The Gradle part LGTM!

@badboy badboy changed the title Bug 1838174 - Upgrade to Gradle 8.1.1 and Android Gradle Plugin 8.0.2 [ci full] Bug 1838174 - Upgrade to Gradle 8.2.1 and Android Gradle Plugin 8.0.2 [ci full] Aug 2, 2023
@badboy badboy enabled auto-merge (rebase) August 11, 2023 09:44
@badboy badboy merged commit 9038cae into main Aug 11, 2023
8 checks passed
@badboy badboy deleted the 1838174/gradle-8-update branch August 11, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travis79 travis79 travis79 approved these changes

@perrymcmanis144 perrymcmanis144 Awaiting requested review from perrymcmanis144 perrymcmanis144 is a code owner automatically assigned from mozilla/glean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badboy @mcarare @travis79