Bug 1841075 - re-export PingRateLimit for RLB's #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrymcmanis144
force-pushed
the
expose_rate_limits
branch
from
54e215b
to
e13ab71
Compare
badboy
reviewed
Jul 11, 2023
badboy
reviewed
Jul 11, 2023
perrymcmanis144
force-pushed
the
expose_rate_limits
branch
from
e13ab71
to
a3daa92
Compare
chutten
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Could land as-is, but could you also jump onto src/configuration.rs and test.rs replace their glean_core::PingRateLimit with crate::PingRateLimit?
The test one is to make sure we're covered. The configuration.rs one ensures if the RLB's PingRateLimit and glean-core's PingRateLimit ever diverge, we're guaranteeing we're exporting the one we need.
perrymcmanis144
force-pushed
the
expose_rate_limits
branch
from
a3daa92
to
b609d22
Compare
chutten
reviewed
Jul 11, 2023
perrymcmanis144
force-pushed
the
expose_rate_limits
branch
from
b609d22
to
8ce6a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.