Bug1626969: Expose locale through the RLB so that it can be set by consumers
#2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis79
requested review from
chutten and
badboy
and removed request for
a team and
chutten
travis79
changed the title
locale through the RLB so that it can be set by consumerslocale through the RLB so that it can be set by consumers
chutten
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Looks good. We might eventually want a Gleannotation on https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/locale to point at the discussion on the bug about what's going on (and to let folks know when it became available for Firefox Desktop).
|
That's a great idea, I'll update the Dictionary with a Gleannotation once this is available in Desktop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.