Bug 1844569 - RLB: Gracefully handle uploader thread start failure #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
changed the title
badboy
force-pushed
the
gracefully-handle-upload-thread-start-failure
branch
from
337609c to
7a08293
Compare
|
I'm still undecided whether I want to land this example test, but at least the RLB code itself is working. |
badboy
requested review from
rosahbruno and
travis79
and removed request for
a team
travis79
approved these changes
Jul 26, 2023
badboy
force-pushed
the
gracefully-handle-upload-thread-start-failure
branch
4 times, most recently
from
b82b670 to
28e6fb2
Compare
There might be cases where we can't properly start the thread, e.g. when out of memory (as it seems to happen on low-end 32bit versions of Firefox). We now avoid the crash. The data should be safely stored on disk and on the next upload it will try again (and hopefully succeed).
badboy
force-pushed
the
gracefully-handle-upload-thread-start-failure
branch
from
28e6fb2 to
56ca432
Compare
badboy
force-pushed
the
gracefully-handle-upload-thread-start-failure
branch
from
56ca432 to
b675ee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be cases where we can't properly start the thread, e.g. when out of memory (as it seems to happen on low-end 32bit versions of Firefox). We now avoid the crash.
The data should be safely stored on disk and on the next upload it will try again (and hopefully succeed).
Still needs some testing. Not sure yet how to inject a thread start failure.