Skip to content

Bug 1809317 - Rust: Remove collect_string method #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

badboy
Copy link
Member

@badboy badboy commented Dec 13, 2023

While technically part of the API since forever, it was never part of the supported public API and not used within the SDK either.

While technically part of the API since forever, it was never part of
the supported public API and not used within the SDK either.
@badboy badboy requested a review from a team as a code owner December 13, 2023 09:42
@badboy badboy requested review from perrymcmanis144 and removed request for a team December 13, 2023 09:42
Copy link
Contributor

@perrymcmanis144 perrymcmanis144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removal of unused code, passes tests so LGTM

@badboy badboy merged commit 84e3b80 into main Dec 13, 2023
@badboy badboy deleted the no-more-collect-string branch December 13, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants