Bug 1870048 - Replace whenTaskAdded with configureEach to avoid unnecesary configuration. #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essary configuration. See https://docs.gradle.org/current/userguide/task_configuration_avoidance.html for details.
travis79
approved these changes
Jan 3, 2024
|
Okay, great. Seems like the failure was just transient. Feel free to land this whenever you like @mcarare, and please let me know when you need to see this in a Glean release and I'll see if I can schedule one. |
|
I don't think I have landing rights on this repo. This would be nice to have as soon as possible because it unblocks some other pending work I have on Firefox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally and this seems to be enough for moving forward with https://bugzilla.mozilla.org/show_bug.cgi?id=1870050.
Also, before going even further #2680 IMO this would be a good test to see if moving to Task Configuration Avoidance would be smooth.