Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1900313 - Bump the string length limit to 255 characters #2857

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Bug 1900313 - Bump the string length limit to 255 characters #2857

merged 2 commits into from
Jun 4, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Jun 3, 2024

No description provided.

@badboy badboy requested a review from a team as a code owner June 3, 2024 09:09
@badboy badboy requested review from chutten and removed request for a team June 3, 2024 09:09
@badboy badboy force-pushed the string-255-length branch from b414539 to c22dbe2 Compare June 3, 2024 09:10
chutten
chutten reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@badboy
Copy link
Member Author

badboy commented Jun 3, 2024

Why?

See https://bugzilla.mozilla.org/show_bug.cgi?id=1899277

@chutten
Copy link
Contributor

chutten commented Jun 3, 2024

Why?

See https://bugzilla.mozilla.org/show_bug.cgi?id=1899277

Right, sorry, follow the links.

@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.60%. Comparing base (42ff601) to head (c22dbe2).

❗ Current head c22dbe2 differs from pull request most recent head 873cc66

Please upload reports for the commit 873cc66 to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2857   +/-   ##
=======================================
  Coverage   18.60%   18.60%           
=======================================
  Files           1        1           
  Lines          43       43           
=======================================
  Hits            8        8           
  Misses         35       35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badboy badboy force-pushed the string-255-length branch from c22dbe2 to 873cc66 Compare June 4, 2024 10:18
@badboy badboy enabled auto-merge (rebase) June 4, 2024 10:18
@badboy badboy merged commit 8c79d3e into main Jun 4, 2024
29 of 30 checks passed
@badboy badboy deleted the string-255-length branch June 4, 2024 11:37
@badboy badboy mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chutten chutten chutten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badboy @chutten