Bug 1906365 - Gradle plugin: support using an external venv. #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozilla-central uses a vendored copy of glean_parser except for the Android parts which currently download their own copy at build time through the Gradle plugin. This commit provides a way to re-use an existing Python virtualenv, in the case of mozilla-central managed by mach, instead of setting up a bespoke one.
badboy
approved these changes
Jul 9, 2024
[doc only]
[doc only]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mozilla-central uses a vendored copy of glean_parser except for the Android parts which currently download their own copy at build time through the Gradle plugin.
This provides a way to re-use an existing Python virtualenv, in the case of mozilla-central managed by mach, instead of setting up a bespoke one.
This has been tested locally and in this Try run where we can see that the gradle-dependencies task (using
gradle --online) doesn't use Miniconda anymore and the Android Searchfox task (usinggradle --offline) succeeds without supplying the glean_parser wheels.