Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through ping schedule for Swift and Kotlin #2967

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Oct 1, 2024

We will most likely need this for the new ping on those platforms.

@badboy badboy force-pushed the kotlin-swift-ping-schedule branch from 6ac987d to 9e04a61 Compare October 2, 2024 10:21
@badboy badboy marked this pull request as ready for review October 2, 2024 10:21
@badboy badboy requested a review from a team as a code owner October 2, 2024 10:21
@badboy badboy requested review from chutten and travis79 and removed request for a team October 2, 2024 10:21
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.54%. Comparing base (4921703) to head (9e04a61).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2967   +/-   ##
=======================================
  Coverage   29.54%   29.54%           
=======================================
  Files           1        1           
  Lines          44       44           
=======================================
  Hits           13       13           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badboy badboy merged commit c99b28c into main Oct 7, 2024
34 checks passed
@badboy badboy deleted the kotlin-swift-ping-schedule branch October 7, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants