-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a crate for the nice control API #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to change or do you want to update the script ?
IMO this should not yet be part of the regular release cycle. It's preview after all and we might just scrape it by January |
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
============================================
- Coverage 75.61% 74.82% -0.79%
+ Complexity 334 333 -1
============================================
Files 98 100 +2
Lines 5736 5795 +59
Branches 715 718 +3
============================================
- Hits 4337 4336 -1
- Misses 879 939 +60
Partials 520 520
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if I understand this properly: it currently depends on and builds on the existing glean-ffi (with its handle) because I've been unreasonably impatient about getting an API in place before those refactors can manifest? : D
Looks good, I found a few instances of leftovers but nothing blocking.
For now this only supports a minimal interface on top of Glean
Because we now expose some re-exported structs, the links might not be correct. I prefer to ignore that for now and fix it later (hopefully with intra-docs links soon)
199e88c
to
0f9f301
Compare
For now this only supports a minimal interface on top of Glean