Fix the Date header generated by glean-core
#993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the sub-second precision and report GMT as timezone identifier, as required by https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Date
badboy
reviewed
Jun 22, 2020
| @@ -88,11 +88,25 @@ impl PingRequest { | |||
| gzipper.finish().ok() | |||
| } | |||
|
|
|||
| /// Creates a formatted date string that can be used with Date headers. | |||
| fn create_date_header_value(current_time: DateTime<Utc>) -> String { | |||
There was a problem hiding this comment.
Not wrong or anything, but this could just be a free-standing function in this module.
There was a problem hiding this comment.
Next time @badboy , next time! :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the sub-second precision and report GMT
as timezone identifier, as required by https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Date