Remove left-over wrong comment. #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
added a commit
to mozilla/glean
that referenced
this pull request
May 4, 2021
Unfortunately there's a left-over "DO NOT COMMIT" in there. Fix is pending upstream: mozilla/glean_parser#322
badboy
added a commit
to mozilla/glean
that referenced
this pull request
May 4, 2021
Unfortunately there's a left-over "DO NOT COMMIT" in there. Fix is pending upstream: mozilla/glean_parser#322
badboy
added a commit
to mozilla/glean
that referenced
this pull request
May 4, 2021
Unfortunately there's a left-over "DO NOT COMMIT" in there. Fix is pending upstream: mozilla/glean_parser#322
mdboom
reviewed
May 4, 2021
Had to fix CI because the location we loaded detekt from is not available anymore. (I also went ahead and made it slightly more secure) |
* This updates detekt to 1.16.0 (from 1.1.1), and updates where it loads it from * This checks the sha256 hash of the file against known correct values. * This does NOT update ktlint. Newer ktlint versions expect globs, not absolute file paths, so it breaks on our list of absolute file paths.
badboy
force-pushed
the
remove-doc-donotcommit
branch
from
a16a24f to
bf467be
Compare
mdboom
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one