Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve the default ping name #376

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Reserve the default ping name #376

merged 1 commit into from
Aug 19, 2021

Conversation

badboy
Copy link
Member

@badboy badboy commented Aug 19, 2021

It can't be used as a ping name, but it can be used in send_in_pings.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@badboy badboy requested a review from brizental August 19, 2021 08:46
It can't be used as a ping name, but it can be used in `send_in_pings`.
@badboy badboy merged commit e4d8fe0 into main Aug 19, 2021
@badboy badboy deleted the default-reserved-ping-name branch August 19, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants