Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove C# support #436

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Remove C# support #436

merged 1 commit into from
Jan 14, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Jan 12, 2022

It was dropped upstream in glean#16c929adf5d483969b605675d2cdac668812a756 end of 2021.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

CHANGELOG.md Outdated
@@ -4,6 +4,7 @@

- Support global file-level tags in metrics.yaml ([bug 1745283](https://bugzilla.mozilla.org/show_bug.cgi?id=1745283))
- Glinter: Reject metric files if they use `unit` by mistake. It should be `time_unit` ([#432](https://github.com/mozilla/glean_parser/pull/432)).
- Remove C# support ([#436](https://github.com/mozilla/glean_parser/pull/436)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godspeed, C# support.

It was dropped upstream in glean#16c929adf5d483969b605675d2cdac668812a756 end of 2021.
@badboy badboy merged commit 0d9a889 into main Jan 14, 2022
@badboy badboy deleted the csharp-is-no-more branch January 14, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants