Some fixes for Rust code generation #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
reviewed
Jun 9, 2022
glean_parser/templates/rust.jinja2
Outdated
| @@ -32,10 +32,10 @@ pub struct {{ obj.name|Camelize }}{{ suffix }} { | |||
| impl ExtraKeys for {{ obj.name|Camelize }}{{ suffix }} { | |||
| const ALLOWED_KEYS: &'static [&'static str] = {{ obj.allowed_extra_keys|extra_keys }}; | |||
|
|
|||
| fn into_ffi_extra(self) -> ::std::collections::HashMap<String, String> { | |||
| fn into_ffi_extra(self) -> ::std::collections::HashMap<std::string::String, std::string::String> { | |||
There was a problem hiding this comment.
Let's use full qualificaation here, as the hashmap also uses with a :: prefix
Suggested change
| fn into_ffi_extra(self) -> ::std::collections::HashMap<std::string::String, std::string::String> { | |
| fn into_ffi_extra(self) -> ::std::collections::HashMap<::std::string::String, ::std::string::String> { |
There was a problem hiding this comment.
I think that should work at least.
- Changes the Rust jinja template to use the `extra_metric_args` format more like the other language templates. - Adds full qualification of `String` to `std::string::String` to silence Rust errors
travis79
force-pushed
the
rust-template-fixes
branch
from
1b14c0f
to
a460d4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extra_metric_argsformat more like the other language templates.Stringtostd::string::Stringto silence Rust errors