Turn a unit field on metrics into a warning for most metrics
#636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
unit-on-metrics-is-a-warning
branch
from
d4e4f2d
to
b35ed13
Compare
This partially reverts #630 (and subsequent fixes) and should unblock all failures in probe-scraper and co.
badboy
force-pushed
the
unit-on-metrics-is-a-warning
branch
from
b35ed13
to
6bb6bdb
Compare
travis79
approved these changes
Nov 3, 2023
Co-authored-by: Travis Long <tlong@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts #630 (and subsequent fixes) and should unblock all failures in probe-scraper and co.
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one