Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #638

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Drop support for Python 3.7 #638

merged 2 commits into from
Dec 12, 2023

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 22, 2023

mach is dropping it too: https://bugzilla.mozilla.org/show_bug.cgi?id=1843209

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@badboy badboy force-pushed the drop-python37 branch 2 times, most recently from 5a3133e to 0a7f356 Compare November 22, 2023 09:20
@badboy badboy requested a review from travis79 November 22, 2023 09:28
@badboy
Copy link
Member Author

badboy commented Nov 22, 2023

Note: this is non-urgent and should still wait for mach to drop support anyway. We also need to adjust the github config to not expect the build-37 task anymore.

@badboy
Copy link
Member Author

badboy commented Dec 12, 2023

@badboy
Copy link
Member Author

badboy commented Dec 12, 2023

I changed the GitHub config to not need the build-37 task, but require the build-311 and build-312 tasks. This is not reflected on this PR, so we gonna admin-merge this. the config is now applied and the PR knows this.

@badboy badboy merged commit 4cc18e6 into main Dec 12, 2023
8 checks passed
@badboy badboy deleted the drop-python37 branch December 12, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants